Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drain jobs of 'Null' dest type #5207

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sidddddarth
Copy link
Member

Description

Drain jobs of Null destType. destType introduced for convenience. Allows events to enjoy all features upto user transformation(including). Router transformations are obviously not allowed for these events.

Linear Ticket

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.78%. Comparing base (9683021) to head (5599376).
Report is 84 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5207      +/-   ##
==========================================
+ Coverage   74.71%   76.78%   +2.06%     
==========================================
  Files         417      439      +22     
  Lines       49913    65383   +15470     
==========================================
+ Hits        37294    50202   +12908     
- Misses      10199    12712    +2513     
- Partials     2420     2469      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 8, 2024

This PR is considered to be stale. It has been open 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

@github-actions github-actions bot added the Stale label Nov 8, 2024
@github-actions github-actions bot closed this Nov 15, 2024
@github-actions github-actions bot deleted the feat.drainNullDestTypeJobs branch December 19, 2024 02:13
@ktgowtham ktgowtham restored the feat.drainNullDestTypeJobs branch January 3, 2025 13:10
@ktgowtham ktgowtham reopened this Jan 3, 2025
@github-actions github-actions bot removed the Stale label Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants