Pin dev image version #383
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geogouz
changed the title
DOCKER_HUB_USERNAME for Docker image namespace
Previously, the workflow used `github.repository_owner` when constructing Docker image tags, which caused push failures if the GitHub username did not match the Docker Hub username. This commit switches to using the `DOCKER_HUB_USERNAME` secret for the base tag, ensuring images are pushed to the correct Docker Hub namespace. This does not affect the official build process where both usernames are identical.
Pin dev builds using ARG TAG, failing early if no tag is provided.
|
Although this pins the version for the dev image, as explained in #379, we need to change also the rucio-dev deployment process (to be able to use also the current master state properly). I will send a different PR for that. |
rdimaio
approved these changes
Mar 12, 2025
rdimaio
reviewed
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin rucio-dev image using ARG TAG, with early failing if no tag is provided.
Also, previously, the workflow used
github.repository_ownerwhen constructing Docker image tags, which caused push failures if the GitHub username did not match the Docker Hub username. This commit switches to using theDOCKER_HUB_USERNAMEsecret for the base tag. This should not affect actually any official build process where both usernames are identical (hence, the Docker Hub namespace should remain correct). The change is mostly for dev support.