Store email using exact casing as provided by user. #4200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4200 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 336 336
Lines 7431 7433 +2
=======================================
+ Hits 7337 7339 +2
Misses 94 94 ☔ View full report in Codecov by Sentry. |
simi
force-pushed
the
case-sensitive-email
branch
from
4a7e282
to
b12e92c
Compare
deivid-rodriguez
approved these changes
Nov 13, 2023
segiddins
approved these changes
Nov 13, 2023
|
@segiddins feel free to merge once you're happy. |
segiddins
approved these changes
Dec 31, 2023
simi
force-pushed
the
case-sensitive-email
branch
2 times, most recently
from
eb81e32
to
cf21d0d
Compare
* Fixes #1763 * Index on lower(email) * Enforce uniqueness on lower(email) * Use Case insensitive email to login
simi
force-pushed
the
case-sensitive-email
branch
from
cf21d0d
to
a02e7af
Compare
jonatas
pushed a commit
to jonatas/rubygems.org
that referenced
this pull request
Jun 7, 2024
* Store email using exact casing as provided by user. * Fixes rubygems#1763 * Index on lower(email) * Enforce uniqueness on lower(email) * Use Case insensitive email to login * Update app/models/user.rb --------- Co-authored-by: Anurag Aryan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on anuragaryan@101df67