Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use correct logger while migration #215

Closed
wants to merge 1 commit into from

Conversation

tsechingho
Copy link
Contributor

It should use $LOG to assign logger, since the CASServer::Model::Ticket module is no more has logger method/variable.

It also needs to require 'casserver/authenticators/base' to make migrate work.

I also fix the rake description.

@mitfik
Copy link

mitfik commented Jun 11, 2014

Hi, thanks for contribution

Actually I do not see any reason why we would like to keep that task but maybe there is some black magic behind it. But anyway, when you are running the server, migration will be done in init_database so it means that there is no need to run that task before.

But since we already have it we will maintain that code of course there is just question if we need to set the $LOG here as AR will use own logger for that purpose.

I prepared a new pull request (#218) based on your code which I think make much more sens in that case. Take a look and give some feedback if this will do the job.

@mitfik mitfik closed this Jun 11, 2014
@tsechingho tsechingho deleted the migrate branch June 11, 2014 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants