Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links in installation (ja) #3104

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

timfanda35
Copy link
Contributor

Fix broken anchor links in installation (ja).

Thank you.

@timfanda35 timfanda35 requested a review from a team as a code owner August 29, 2023 07:29
@@ -34,7 +34,7 @@ Windows 10 では、[Windows Subsystem for Linux][wsl] を使用して、サポ
* [Arch Linux](#pacman)
* [macOS](#homebrew)
* [FreeBSD](#freebsd)
* [OpenBSD](#openbsd)
* [OpenBSD](#doas)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The #doas has been in OpenBSD section (ja).

I first saw #doas in OpenBSD section (ja), and I saw the most of the OS list use the package manager name as link. So I use the #doas for OpenBSD in the PR https://github.com/ruby/www.ruby-lang.org/pull/3103/files#diff-22f637eb1eb70979587a5c96614fddb46bdf7ae2d34a04ee30915ba526e76fd1R175, and this PR.

I just found it use #openbsd in (en)

, would it be better to follow the (en) to use #openbsd?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The #doas has been in OpenBSD section (ja).

Thanks. I missed it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be better to follow the (en) to use #openbsd?

+1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the links to follow (en) version.
I also update the PR: #3103

Thank you.

@timfanda35 timfanda35 force-pushed the fix-installation-links-ja branch 2 times, most recently from 961c1b6 to 5750b3c Compare September 4, 2023 05:01
@hsbt hsbt merged commit be4842b into ruby:master Dec 1, 2023
1 check passed
@timfanda35 timfanda35 deleted the fix-installation-links-ja branch June 12, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants