Fix FAQ: block params shadow outer lvars #2851
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is misleading: "that variable will be modified by the call to the block"
The outer variable isn't mutated; they are different variables. The name points to one variable outside the block and a different variable inside the block. I'm not sure if my proposed change is better though! 😉
Also, I moved the "arguments are passed" paragraph to the top. The original ordering was fine: it's reasonable to describe how to define block parameters first, and then how to pass arguments in them. But it seems like reversing the order is the most direct answer to the question, as the question is worded. Perhaps the original order was better, but we should add a second question heading: "How do I define a block's parameters"