Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable redirect to outdated translations #1828

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

znz
Copy link
Member

@znz znz commented Sep 11, 2018

I think redirecting to outdated translations is not good.
And I do not want to maintain languages map manually.
So I think it should stop to redirect automatically.
Some languages are commented out in LANGS_MAP, because original LANGS does not include them.
Magic number about_6_months_ago is to stop redirecting to pt which is not included in original LANGS and latest posts are 2017-12-14.

ref #1827

@stomar
Copy link
Contributor

stomar commented Sep 29, 2018

I'm not convinced yet that automatic disabling is a good thing.

Besides that, I think "_plugins/translation_status.rb" is not the right place to define the "languages_json" tag, it should be separate.

@deivid-rodriguez
Copy link
Contributor

What about remembering user's language choice on a cookie. Would that be acceptable?

@VagishVela
Copy link
Contributor

VagishVela commented Oct 4, 2018

@deivid-rodriguez I wonder if we could show a banner to ask the user if this the language they want the first time they visit and store it in a cookie? If they change to another language from the footer maybe show them a bar at the top asking if they want to save this as their default language?

The logic could be that if the cookie exists it overrides the auto-redirect.

@deivid-rodriguez
Copy link
Contributor

Yeah, that would definitely work for me!

@stomar
Copy link
Contributor

stomar commented Oct 4, 2018

Personally, I do not like handling cookies, I'd prefer keeping the site as simple as possible.

@deivid-rodriguez
Copy link
Contributor

Do you have any other proposals to fix #1827, then?

Of course, as a user I can change the language of my browser, or go to the footer and click on English every time I visit the site, or remember to type ruby-lang.org/en every time I visit the site. But I think we can agree that it's not a very good user experience. All that assuming that I'm aware that my language translation is outdated. Otherwise I'll just mistakenly assume that the information I'm given is the latest.

stomar added a commit that referenced this pull request Mar 13, 2019
Do not automatically redirect from /index.html to unmaintained
or outdated translations. Currently this affects pl, tr.

Related to #1828.
igaiga pushed a commit to igaiga/www.ruby-lang.org that referenced this pull request Mar 21, 2019
Do not automatically redirect from /index.html to unmaintained
or outdated translations. Currently this affects pl, tr.

Related to ruby#1828.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants