-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable redirect to outdated translations #1828
base: master
Are you sure you want to change the base?
Conversation
I'm not convinced yet that automatic disabling is a good thing. Besides that, I think "_plugins/translation_status.rb" is not the right place to define the "languages_json" tag, it should be separate. |
What about remembering user's language choice on a cookie. Would that be acceptable? |
@deivid-rodriguez I wonder if we could show a banner to ask the user if this the language they want the first time they visit and store it in a cookie? If they change to another language from the footer maybe show them a bar at the top asking if they want to save this as their default language? The logic could be that if the cookie exists it overrides the auto-redirect. |
Yeah, that would definitely work for me! |
Personally, I do not like handling cookies, I'd prefer keeping the site as simple as possible. |
Do you have any other proposals to fix #1827, then? Of course, as a user I can change the language of my browser, or go to the footer and click on English every time I visit the site, or remember to type |
Do not automatically redirect from /index.html to unmaintained or outdated translations. Currently this affects pl, tr. Related to #1828.
Do not automatically redirect from /index.html to unmaintained or outdated translations. Currently this affects pl, tr. Related to ruby#1828.
I think redirecting to outdated translations is not good.
And I do not want to maintain languages map manually.
So I think it should stop to redirect automatically.
Some languages are commented out in
LANGS_MAP
, because original LANGS does not include them.Magic number
about_6_months_ago
is to stop redirecting topt
which is not included in original LANGS and latest posts are 2017-12-14.ref #1827