Various test and CI improvements #910
Open
+62
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The directory used to contain a copy of envutil.rb. It is now gone since we started using the test-unit-ruby-core gem. The top-level lib directory is automatically added by Rake::TestTask.
Changes include: - Remove Rake task dependency to "debug" and "debug_compiler" from "compile" and "test". Let the workflow explicitly run them as necessary. Since we use separate rake invocations for compiling and running tests, the dependency causes repeated debug prints. - Remove printing Ruby version from the debug tasks as it is not necessary. The ruby/setup-ruby action shows the activated version. - Let "debug" rake task call FileUtils#ruby with verbose: false to avoid printing the script itself.
Update GitHub Actions workflows to set OSSL_TEST_ALL=1. Exclude a few slow tests that are not critical for local development, unless OSSL_TEST_ALL=1 is set. The bindings code paths are still reached by other tests with smaller inputs, and failures in those would likely indicate an issue in OpenSSL rather than in the bindings. Newly excluded tests include generating large DSA keys and measuring CRYPTO_memcmp() timing. These tests currently take nearly half of the total runtime.
Use OpenSSL::TestCase instead of OpenSSL::SSLTestCase. Prefer assert_true and assert_false over the bare assert and refute. OpenSSL.fixed_length_secure_compare and OpenSSL.secure_compare will only return true or false, and it should be checked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rakefile: do not add test/openssl to the load paths
The directory used to contain a copy of envutil.rb. It is now gone since
we started using the test-unit-ruby-core gem.
The top-level lib directory is automatically added by Rake::TestTask.
.github/workflows/test.yml: update debug print
Changes include:
Remove Rake task dependency to "debug" and "debug_compiler" from
"compile" and "test". Let the workflow explicitly run them as
necessary. Since we use separate rake invocations for compiling and
running tests, the dependency causes repeated debug prints.
Remove printing Ruby version from the debug tasks as it is not
necessary. The ruby/setup-ruby action shows the activated version.
Let "debug" rake task call FileUtils#ruby with verbose: false to
avoid printing the script itself.
Move slow tests to OSSL_TEST_ALL=1 only
Update GitHub Actions workflows to set OSSL_TEST_ALL=1.
Exclude a few slow tests that are not critical for local development,
unless OSSL_TEST_ALL=1 is set. The bindings code paths are still reached
by other tests with smaller inputs, and failures in those would likely
indicate an issue in OpenSSL rather than in the bindings.
Newly excluded tests include generating large DSA keys and measuring
CRYPTO_memcmp() timing. These tests currently take nearly half of the
total runtime.
test/openssl/test_ossl.rb: fix style issues
Use OpenSSL::TestCase instead of OpenSSL::SSLTestCase.
Prefer assert_true and assert_false over the bare assert and refute.
OpenSSL.fixed_length_secure_compare and OpenSSL.secure_compare will
only return true or false, and it should be checked.
test/openssl/test_ts.rb: make assert_raise blocks smaller