ssl: add SSLSocket#peer_signature_digest_name, #peer_signature_name, #group_name #908
Conversation
| assert_equal('X25519MLKEM768', ssl.group_name) | ||
| else | ||
| assert_equal('x25519', ssl.group_name) | ||
| end |
There was a problem hiding this comment.
Note I am investigating which commit between the OpenSSL 3.5 and 3.4 made this change in the SSL_get0_group_name(). I haven't found the change in the OpenSSL documents.
There was a problem hiding this comment.
I think you can force one with SSLContext#groups= now. Perhaps you can just add assertions in the existing tests for it?
junaruga
force-pushed
the
wip/ssl-client-data
branch
from
45025e0 to
b13cd03
Compare
| GetSSL(self, ssl); | ||
| if (!SSL_get0_peer_signature_name(ssl, &name)) | ||
| return Qnil; | ||
| return rb_str_new2(name); |
There was a problem hiding this comment.
| return rb_str_new2(name); | |
| return rb_str_new_cstr(name); |
new2 is a soft-deprecated macro for this function.
|
Honestly, I'm not so sure if there are actual demand for these methods, though I have no objection to adding them if they turn out to be useful.
Re [BTW, the peer/local split in the getter functions is a pity, since the methods (the corresponding OpenSSL API) for setting the allowed signature algorithms use the server/client split instead.] As for |
@rhenium This PR is related to #894 - Add features to get the following data from a TLS client.
Note I added the
#include <openssl/obj_mac.h>forNID_undefand#include <openssl/objects.h>for theOBJ_nid2sn().I am not sure about the best location where I should put these new logic, the functions and unit tests in the files. I would appreciate if you tell me the best location.
You can also just cherry-pick this PR or refer to this PR or create your new PR.
Could you review the PR? Thank you!