Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃攰 Warn about deprecated #responses usage #97

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nevans
Copy link
Collaborator

@nevans nevans commented Jan 7, 2023

This was extracted from #93 and split into a separate PR.

This allows us to prepare dependent projects for the new behavior before their logs are flooded with deprecation warnings.

Also adds Net::IMAP.attr_accessor :silence_thread_safety_deprecation_warnings. This is provided as a temporary workaround, until dependant projects can update their usage.

@nevans nevans requested a review from shugo January 7, 2023 15:30
@nevans
Copy link
Collaborator Author

nevans commented Jan 7, 2023

@shugo Because #93 is such a big change to existing usage, I split the deprecation warnings into a separate PR. I'd like to take a look at the top reverse dependencies and submit forward-compatible PRs to them, before we start flooding their logs with new warnings!

shugo
shugo previously approved these changes Jan 10, 2023
Copy link
Member

@shugo shugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine!

@shugo
Copy link
Member

shugo commented Jan 10, 2023

FYI, warn(msg, category: :deprecated) doesn't show warnings by default.
However, Net::IMAP users may not use -W:deprecated....

@nevans
Copy link
Collaborator Author

nevans commented Jan 10, 2023

FYI, warn(msg, category: :deprecated) doesn't show warnings by default. However, Net::IMAP users may not use -W:deprecated....

Thanks. I had forgotten about that.

If I remember correctly, I did try to use category: :deprecated on the deprecated SASL mechanisms, but I removed it because that kwarg wasn't supported in 2.6 or 2.7. When we do require ruby 3.0+, should we switch to use category: :deprecated?

@shugo
Copy link
Member

shugo commented Jan 11, 2023

If I remember correctly, I did try to use category: :deprecated on the deprecated SASL mechanisms, but I removed it because that kwarg wasn't supported in 2.6 or 2.7. When we do require ruby 3.0+, should we switch to use category: :deprecated?

Yes, you're right. I forgot that category: :deprecated was not supported in 2.7.

@nevans nevans force-pushed the response-handlers branch 2 times, most recently from 857dabb to bbaa32a Compare August 5, 2023 02:56
@nevans nevans marked this pull request as draft August 29, 2023 14:09
@nevans nevans force-pushed the response-handlers branch 2 times, most recently from d800e82 to c58afb8 Compare September 26, 2023 01:25
@nevans nevans force-pushed the response-handlers branch 2 times, most recently from c835ad5 to ecba223 Compare November 7, 2023 04:28
@nevans nevans added the v0.5 label May 19, 2024
This was extracted from #93 and split into a separate PR.

This allows us to prepare dependent projects for the new behavior before
their logs are flooded with deprecation warnings.
This is provided as a temporary workaround, until dependant projects can
update their usage.

A future release will remove this backwards compatibility, but no sooner
than one year after the release that contains this deprecation warning.
@nevans nevans added this to the v0.5 milestone May 19, 2024
@nevans nevans removed the v0.5 label May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants