Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃挜 Drop ruby 2.7 and 3.0 support, and require 3.1 #276

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nevans
Copy link
Collaborator

@nevans nevans commented May 2, 2024

Ruby 2.7 EOL was 2023-03-31.
Ruby 3.0 EOL was 2024-04-23.

Currently, net-imap remains compatible with ruby 2.7. But some of my unmerged branches do use ruby 3.1 syntax (e.g: updated pattern matching and endless method definitions). It will be nice if I don't need to update those branches for compatibility with EOL rubies.


NOTE: The next release after this is merged should be v0.5.0.

@nevans
Copy link
Collaborator Author

nevans commented May 2, 2024

@shugo @hsbt Are you okay with bumping the minimum ruby version for the 0.5.x releases?

As a policy, I'd like to only change the minimum required ruby when we bump our major.minor version. And I'd like to only bump the major.minor version once a year, after the oldest version of ruby reaches its end of life. This way, net-imap's major.minor will be approximately synchronized with ruby's.

Copy link
Member

@shugo shugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds reasonable 馃憤

Copy link
Member

@hsbt hsbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憣

@nevans nevans force-pushed the require-ruby-3.1 branch 2 times, most recently from 1cf80d7 to 979d82f Compare May 19, 2024 14:03
@nevans nevans added the v0.5 label May 19, 2024
Ruby 2.7 EOL was 2023-03-31.
Ruby 3.0 EOL was 2024-04-23.

Currently, net-imap remains compatible with ruby 2.7.  But some of my
unmerged branches do use ruby 3.1 syntax (e.g: updated pattern matching
and endless method definitions).  It will be nice if I don't need to
update those branches for compatibility with EOL rubies.

----

_**NOTE:** The next release after this is merged should be v0.5.0._
@nevans nevans added this to the v0.5 milestone May 19, 2024
@nevans nevans removed the v0.5 label May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants