Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add grammar/code directory types #417

Merged
merged 8 commits into from
May 17, 2024

Conversation

Little-Rubyist
Copy link
Contributor

It's been a while since I added types. (sorry...)

The surroundings directory in Grammar is quite complex, with many uncertainties, but I have confirmed that all type checks are cleared.

def reference_to_c: (Reference ref) -> String
def position_in_rhs: () -> Integer
def rhs: () -> Array[Grammar::Symbol]
def lhs: () -> Symbol
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any intention to use "Symbol" however rhs is Grammar::Symbol.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, seems like a simple mistake. I fixed.

@yui-knk yui-knk merged commit 142cce4 into ruby:master May 17, 2024
16 checks passed
@Little-Rubyist Little-Rubyist deleted the add_grammar_code_rbs branch May 17, 2024 06:32
@yui-knk
Copy link
Collaborator

yui-knk commented May 17, 2024

Thanks for the PR! This is OSS project then you do not need to apologize the pace of your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants