-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add grammar/code directory types #417
Conversation
def reference_to_c: (Reference ref) -> String | ||
def position_in_rhs: () -> Integer | ||
def rhs: () -> Array[Grammar::Symbol] | ||
def lhs: () -> Symbol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any intention to use "Symbol" however rhs
is Grammar::Symbol
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, seems like a simple mistake. I fixed.
Thanks for the PR! This is OSS project then you do not need to apologize the pace of your work. |
It's been a while since I added types. (sorry...)
The surroundings directory in Grammar is quite complex, with many uncertainties, but I have confirmed that all type checks are cleared.