Fix for weird effects on some devices

- Use margin instead of padding for the TranslucentStyle. Padding was messing up on some devices
rubengees · Feb 5, 2016 · 1b25f5c · 1b25f5c
1 parent fb2d61f
commit 1b25f5c
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 10 deletions.
diff --git a/README.md b/README.md
@@ -18,7 +18,7 @@ repositories {
 }
 
 dependencies {
-    compile ('com.github.rubengees:introduction:1.1.5@aar'){
+    compile ('com.github.rubengees:introduction:1.1.6@aar'){
         transitive = true;
     }
 }

diff --git a/build.gradle b/build.gradle
@@ -3,7 +3,7 @@ buildscript {
         jcenter()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:2.0.0-alpha8'
+        classpath 'com.android.tools.build:gradle:2.0.0-beta2'
         classpath 'com.github.dcendents:android-maven-gradle-plugin:1.3'
     }
 }

diff --git a/library/build.gradle b/library/build.gradle
@@ -10,8 +10,8 @@ android {
     defaultConfig {
         minSdkVersion 10
         targetSdkVersion 23
-        versionCode 11
-        versionName "1.1.5"
+        versionCode 12
+        versionName "1.1.6"
         consumerProguardFiles 'proguard-rules.pro'
     }
 }

diff --git a/library/src/main/java/com/rubengees/introduction/style/TranslucentStyle.java b/library/src/main/java/com/rubengees/introduction/style/TranslucentStyle.java
@@ -40,12 +40,10 @@ public void applyStyleOnActivityView(@NonNull Activity activity, @NonNull ViewGr
         SystemBarTintManager tintManager = new SystemBarTintManager(activity);
         SystemBarTintManager.SystemBarConfig config = tintManager.getConfig();
 
-        RelativeLayout.LayoutParams params =
-                (RelativeLayout.LayoutParams) bottomBar.getLayoutParams();
-        params.height = params.height + config.getPixelInsetBottom();
-        bottomBar.setLayoutParams(params);
-
-        bottomBar.setPadding(0, -config.getPixelInsetBottom(), config.getPixelInsetRight(), 0);
+        RelativeLayout.MarginLayoutParams params =
+                (RelativeLayout.MarginLayoutParams) bottomBar.getLayoutParams();
+        params.bottomMargin = params.bottomMargin + config.getPixelInsetBottom();
+        params.rightMargin = params.rightMargin + config.getPixelInsetRight();
     }
 
     @Override