Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dns.rdata.load_all_types(). #1095

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Add dns.rdata.load_all_types(). #1095

merged 1 commit into from
Jun 27, 2024

Conversation

rthalley
Copy link
Owner

This PR provides dns.rdata.load_all_types(), which loads all rdata implementations instead of dynamically loading them on use. This is useful in some cases, as in issue [#1083] or if using chroot().

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 93.91%. Comparing base (369a846) to head (788eddd).

Files Patch % Lines
dns/rdata.py 50.00% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1095      +/-   ##
==========================================
- Coverage   93.92%   93.91%   -0.01%     
==========================================
  Files         143      143              
  Lines       13389    13396       +7     
  Branches     2607     2609       +2     
==========================================
+ Hits        12575    12581       +6     
- Misses        480      481       +1     
  Partials      334      334              
Flag Coverage Δ
unittests 93.87% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rthalley rthalley merged commit 84de5d6 into main Jun 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants