Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Tudoor fix should not eat valid Truncated exceptions [#1053] #1054

Merged
merged 2 commits into from
Feb 18, 2024

Conversation

rthalley
Copy link
Owner

@rthalley rthalley commented Feb 18, 2024

The Tudoor fix eats valid Truncated exceptions preventing resolver failover to TCP and causing timeouts instead. This fix handles Truncated exceptions explicitly, ignoring ones that are invalid (e.g. wrong query id or question) but raising those that are valid.

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@41b991e). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1054   +/-   ##
=======================================
  Coverage        ?   94.08%           
=======================================
  Files           ?      142           
  Lines           ?    13141           
  Branches        ?     2532           
=======================================
  Hits            ?    12364           
  Misses          ?      463           
  Partials        ?      314           
Flag Coverage Δ
unittests 94.04% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rthalley rthalley merged commit 2ab3d16 into main Feb 18, 2024
9 checks passed
@rthalley rthalley deleted the tudoor-trunc branch February 18, 2024 18:27
rthalley added a commit that referenced this pull request Feb 18, 2024
* The Tudoor fix should not eat valid Truncated exceptions [##1053]

* Make logic more readable

(cherry picked from commit 2ab3d16)
amitsrivastava added a commit to cloudera/hue that referenced this pull request Jul 22, 2024
amitsrivastava added a commit to cloudera/hue that referenced this pull request Jul 22, 2024
Based on the dnspython upstream commits

1. rthalley/dnspython@f66e25b
Upstream PR: rthalley/dnspython#1044

2. rthalley/dnspython@0ea5ad0
Upstream PR: rthalley/dnspython#1054

Change-Id: I20193e975a05a8206f8beba7e9be17f23594afcd
amitsrivastava added a commit to cloudera/hue that referenced this pull request Jul 22, 2024
Based on the dnspython upstream commits

1. rthalley/dnspython@f66e25b
Upstream PR: rthalley/dnspython#1044

2. rthalley/dnspython@0ea5ad0
Upstream PR: rthalley/dnspython#1054

Change-Id: I20193e975a05a8206f8beba7e9be17f23594afcd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants