Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS-over-HTTP3 #1048

Merged
merged 2 commits into from
Feb 24, 2024
Merged

DNS-over-HTTP3 #1048

merged 2 commits into from
Feb 24, 2024

Conversation

rthalley
Copy link
Owner

This is a draft of direct support of DNS-over-HTTP/3 by calling into aioquic while we're waiting for httpx to add support.

@rthalley
Copy link
Owner Author

While working on the typing, I discovered a bug in the type signature for https(). It had family: Optional[int] = socket.AF_UNSPEC but the right type is family: int = socket.AF_UNSPEC and this is what was documented. I just fixed this as I don't think anyone would be passing None here, but if people think I should allow None and map it to socket.AF_UNSPEC for maximum backwards compatibility, let me know!

@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2024

Codecov Report

Attention: 77 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@41b991e). Click here to learn what that means.

Files Patch % Lines
dns/query.py 58.57% 16 Missing and 13 partials ⚠️
dns/asyncquery.py 75.00% 5 Missing and 7 partials ⚠️
dns/quic/_asyncio.py 70.27% 5 Missing and 6 partials ⚠️
dns/quic/_sync.py 79.24% 4 Missing and 7 partials ⚠️
dns/quic/_trio.py 72.72% 3 Missing and 6 partials ⚠️
dns/quic/_common.py 89.79% 3 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1048   +/-   ##
=======================================
  Coverage        ?   93.71%           
=======================================
  Files           ?      142           
  Lines           ?    13381           
  Branches        ?     2605           
=======================================
  Hits            ?    12540           
  Misses          ?      494           
  Partials        ?      347           
Flag Coverage Δ
unittests 93.67% <73.37%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rthalley rthalley marked this pull request as ready for review February 17, 2024 15:19
@rthalley rthalley merged commit e9d58f2 into main Feb 24, 2024
9 checks passed
@rthalley rthalley deleted the h3 branch February 24, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants