pref: instead of debounce 20ms, using requestIdleCallback to delay calculation #425
+15
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
myNameIsDu
force-pushed
the
pref/delay-calculation
branch
from
1976b51
to
159d2a5
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9bc1bba:
|
myNameIsDu
force-pushed
the
pref/delay-calculation
branch
from
159d2a5
to
9bc1bba
Compare
simonguo
reviewed
Apr 26, 2023
| if (idleCallbackId) { | ||
| window.cancelIdleCallback(idleCallbackId); | ||
| } | ||
| idleCallbackId = window.requestIdleCallback(deadline => { |
There was a problem hiding this comment.
Safari browser does not support requestIdleCallback.
| idleCallbackId = null; | ||
| calculateTableWidth(entries[0].contentRect.width); | ||
| } else { | ||
| changeTableWidthWhenResize(entries); |
There was a problem hiding this comment.
Suggested change
| changeTableWidthWhenResize(entries); | |
| // If there is not enough idle time, try again in a future idle period. | |
| // Use setTimeout to avoid stack overflow if this function is called too frequently. | |
| setTimeout(() => { | |
| changeTableWidthWhenResize(entries); | |
| }, 50); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.