Skip to content

Do not support block expectations on HaveBeenPerformed/HaveBeenEnqueued #2851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2025

Conversation

samk1
Copy link
Contributor

@samk1 samk1 commented Jun 18, 2025

Fixes #2850

@JonRowe
Copy link
Member

JonRowe commented Jun 19, 2025

I need to fix the build before this can be merged but it looks fine implementation wise thank you!

@JonRowe
Copy link
Member

JonRowe commented Jun 19, 2025

Can you rebase? The build has been fixed

@JonRowe JonRowe closed this Jun 19, 2025
@JonRowe JonRowe reopened this Jun 19, 2025
@samk1
Copy link
Contributor Author

samk1 commented Jun 19, 2025

Can you rebase? The build has been fixed

Done

@JonRowe JonRowe merged commit ce9663e into rspec:main Jun 19, 2025
11 checks passed
JonRowe added a commit that referenced this pull request Jun 19, 2025
JonRowe added a commit that referenced this pull request Jun 19, 2025
@JonRowe
Copy link
Member

JonRowe commented Jun 19, 2025

Thanks! Released in 8.0.1

@samk1
Copy link
Contributor Author

samk1 commented Jun 19, 2025

Cheers, thanks for the quick turnaround on the release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HaveBeenEnqueued/HaveBeenPerformed supports block expectations?
2 participants