[FIX] Arc regex to no longer match on dmarc= #4960
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstakhov
reviewed
May 13, 2024
| @@ -639,7 +639,7 @@ local function prepare_arc_selector(task, sel) | |||
| local ar_header = task:get_header('Authentication-Results') | |||
|
|
|||
| if ar_header then | |||
| local arc_match = string.match(ar_header, 'arc=(%w+)') | |||
| local arc_match = string.match(ar_header, '[; ]arc=(%w+)') | |||
There was a problem hiding this comment.
It won't match a string where arc= is the first element...
There was a problem hiding this comment.
I don't see any possible choices to match that thing with Lua match I'm afraid. With PCRE it's trivial.
There was a problem hiding this comment.
aaah pants. I'll have another go at this soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4959
