Fix neural check in lua_cfg_transform.lua #4946
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We might also check if there are any rules defined there |
|
i have no clue why this makes some tests fail. |
|
Tests are failing because |
fatalbanana
reviewed
May 29, 2024
| @@ -544,7 +544,7 @@ return function(cfg) | |||
| end | |||
|
|
|||
| -- If neural network is enabled we MUST have `check_all_filters` flag | |||
| if cfg.neural then | |||
| if cfg.neural and cfg.neural.enabled then | |||
There was a problem hiding this comment.
Suggested change
| if cfg.neural and cfg.neural.enabled then | |
| if cfg.neural and cfg.neural.enabled ~= false and next(cfg.neural.rules or {}) then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check for neural.enabled to see if it's enabled. only checking for neural is always true unless someone messed with config files.