Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provides reworked AeronTransport implementation #972

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

OlegDokuka
Copy link
Member

Signed-off-by: Oleh Dokuka [email protected]

@OlegDokuka OlegDokuka added this to the 1.x Backlog milestone Jan 1, 2021
@@ -11,7 +11,7 @@
protected UnboundedProcessor sender = new UnboundedProcessor();

public BaseDuplexConnection() {
onClose.doFinally(s -> doOnClose()).subscribe();
onClose.subscribe(null, t -> doOnClose(), this::doOnClose);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated, non-blocking. What's the plan with the deprecation? reactor/reactor-core#2431 (comment)

Should onClose be updated?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. I will do that in a separate PR

@@ -11,7 +11,7 @@
protected UnboundedProcessor sender = new UnboundedProcessor();

public BaseDuplexConnection() {
onClose.doFinally(s -> doOnClose()).subscribe();
onClose.subscribe(null, t -> doOnClose(), this::doOnClose);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this still run for cancellation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think it should at all. In this case, we wait for onError or onComplete

.subscribe(
null,
__ -> {
synchronized (activeConnections) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this duplication be improved by using doOnTerminate or doFinally?

@yschimke
Copy link
Member

yschimke commented Jan 2, 2021

Low value drive by review of a draft PR. Mainly me trying to learn from the PR.

@OlegDokuka OlegDokuka linked an issue Apr 27, 2021 that may be closed by this pull request
OlegDokuka and others added 10 commits June 9, 2021 20:43
…on/AeronClientTransport.java

Co-authored-by: Yuri Schimke <[email protected]>
…on/AeronServerTransport.java

Co-authored-by: Yuri Schimke <[email protected]>
uncomments largePayload tests

Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is using Aeron stable with RSocket?
2 participants