WIP Rails 7 2 support #2424
Open
WIP Rails 7 2 support #2424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure this should happen. But the on_load hook version is not happening early enough for the Rakefile's clear task.
This makes the quote_column_name and quote_table_names methods organized more similarly to how they are the new mysql and postgres adapters.
Active record wants '?' as a bind placeholder. Without this it will not
provide bind variables to exec.
Oracle requires :N style bind parameters, so it a translation is
required.
Something went wrong in the translation between rails 7.1 and rails 7.2
so that the where("CONTAINS(table.col, ?, 0) >0", term) was no longer
getting it's bind parameter translated to ':a1' like it should be.
This change drops down to AREL nodes which ensures that the contains
query is getting passed through the visitor pattern, specifically
hitting the visit_Arel_Nodes_BindParam method to convert the param to
':a1'.
I still do not understand what changed in rails, but this workaround is
effective.
This was referenced Jan 31, 2025
Explain now returns an object. We need to coerce it into a string for rspec comparisons. https://blog.saeloun.com/2024/11/21/rails-7-2-adds-support-for-explain-method-to-activerecord-relation/ rails/rails@c1ea574
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes significant progress towards supporting Rails 7.2