-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add url to the release in the supplementary material #14
Conversation
Pass in the url to the script so that the link to the supplementary info will go to the current release
So that supplemental link goes to the current release
Update README.md
sync to main
added html_url to cli.upload_archive() and wasn't supposed to be there
This is a great idea! But let's make this still a variable that the user provides. The reason is because they might use the action on a non-release event, or want a different URL used. |
And it should still be optional, meaning the default for html url is set to None and then in the action python script we check if it is defined, and only set it if that's the case. Otherwise folks using the action now will get different behavior. |
Got it. Where would they define the html_url? Updating the workflow every time a release is made seems non ideal. Perhaps defining an option like
And if html_url == "release_url" then that url is used? But default is None so behavior doesn't change? |
|
Signed-off-by: vsoch <[email protected]>
Update html url to be an optional parameter
Closing this pull request since I merged in your changes. |
This addresses issue #13