Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add std:: prefix to all move() invocations, to address clang -Wunqualified-std-cast-call build warning #3387

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dholbert
Copy link
Contributor

This fixes #3386.

In a few cases this patch also rewraps the affected line, aiming to roughly preserve the prior line length and optimize for readability.

…ified-std-cast-call build warning.

This fixes rr-debugger#3386.

In a few cases this patch also rewraps the affected line, aiming to roughly
preserve the prior line length and optimize for readability.
@dholbert
Copy link
Contributor Author

Not sure what the failing checks are about; I don't they're related to this patch.

The issue seems to be a test-failure in early_error

�_bk;t=1666548478961�1275/1329 Test  #912: early_error ............................................***Failed  Error regular expression found in output. Regex=[FAILED]  0.04 sec
�_bk;t=1666548478962�FAILED at src/test/early_error.c:60: !(WTERMSIG(status) == SIGABRT) errno:0 (Success)
�_bk;t=1666548478962�source_dir/src/test/early_error.run: line 5: 113837 Aborted                 _RR_TRACE_DIR="$workdir" test-monitor $TIMEOUT record.err "./$TESTNAME-$nonce" $(which rr) $GLOBAL_OPTIONS record $LIB_ARG $RECORD_ARGS "./$TESTNAME-$nonce"
�_bk;t=1666548478962�Test 'early_error' FAILED: didn't get expected startup error
�_bk;t=1666548478962�Test early_error failed, leaving behind /cache/build/default-armageddon-4/julialang/rr/obj/my_temp_parent_dir/jl_wTGRB1/rr-test-early_error-taAeDgl9e
�_bk;t=1666548478962�To replay the failed test, run
�_bk;t=1666548478962�  _RR_TRACE_DIR=/cache/build/default-armageddon-4/julialang/rr/obj/my_temp_parent_dir/jl_wTGRB1/rr-test-early_error-taAeDgl9e rr replay
�_bk;t=1666548478962�

No idea what that's about, but it doesn't seem like something that my non-functional std::-prefixing changes would've caused or influenced...

@rocallahan
Copy link
Collaborator

Tests pass locally so I merged this. 05b8393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants