Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: custom parameters for Callbacks #1990

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

add: custom parameters for Callbacks #1990

wants to merge 3 commits into from

Conversation

jazken
Copy link

@jazken jazken commented Oct 9, 2023

Just started using this library and hope to have the feature to pass in custom parameters into callbacks.

#1645 Another issue highlighting this feature.
I am setting up an initial pull request to add params to callbacks.

The method of implementation is to add an optional dictionary params to the callback class, allowing any type of callback to use this to expand parameters for callbacks.

@jazken jazken marked this pull request as draft October 9, 2023 09:16
@jazken jazken changed the title add: custom parameters add: custom parameters for Callbacks Oct 9, 2023
@selwin
Copy link
Collaborator

selwin commented Oct 18, 2023

Can you add tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants