Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

columnkey update to parentlabel for subtable #1380

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

hrutik7
Copy link

@hrutik7 hrutik7 commented Aug 11, 2023

No description provided.

@vercel
Copy link

vercel bot commented Aug 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
rowy-typedoc ⬜️ Ignored (Inspect) Visit Preview Aug 16, 2023 4:39pm

@vercel
Copy link

vercel bot commented Aug 11, 2023

@hrutik7 is attempting to deploy a commit to the Rowy Team on Vercel.

A member of the Team first needs to authorize it.

@il3ven
Copy link
Contributor

il3ven commented Aug 21, 2023

@shamsmosowi I am trying to merge this PR. Can you confirm the following?

Is this according to the design?

Is subcollectionid the correct name for the config?

onChange={(e) =>
{ onChange("subcollectionid")(e.target.value)
setInputValue(e.target.value)}
}

@shamsmosowi
Copy link
Member

@shamsmosowi I am trying to merge this PR. Can you confirm the following?

Is this according to the design?

#### Is `subcollectionid` the correct name for the config? https://github.com/rowyio/rowy/blob/d703f9ec53f7e47811f87c8cdc71c812c9766749/src/components/fields/SubTable/Settings.tsx#L35-L38

the design is good, and it should be subcollectionId

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants