Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (Asset updates): Allow absent files #7926

Merged
merged 1 commit into from May 14, 2024

Conversation

OjusWiZard
Copy link
Member

Closes https://github.com/orgs/rotki/projects/11/views/2?pane=issue&itemId=62277464

Checklist

  • Allow asset updates if one or more update files are missing, and test.

@OjusWiZard OjusWiZard added the ready for peer review Backend PR ready to be reviewed by colleagues label May 13, 2024
rotkehlchen/globaldb/updates.py Outdated Show resolved Hide resolved
rotkehlchen/globaldb/updates.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 80.78%. Comparing base (82342a4) to head (06aef95).
Report is 409 commits behind head on bugfixes.

Files Patch % Lines
rotkehlchen/globaldb/updates.py 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           bugfixes    #7926      +/-   ##
============================================
+ Coverage     80.26%   80.78%   +0.52%     
============================================
  Files          1098     1177      +79     
  Lines        106799   108378    +1579     
  Branches      13360    12842     -518     
============================================
+ Hits          85717    87552    +1835     
+ Misses        18995    18598     -397     
- Partials       2087     2228     +141     
Flag Coverage Δ
backend 80.97% <83.33%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rotkehlchen/globaldb/updates.py Outdated Show resolved Hide resolved
rotkehlchen/tests/unit/globaldb/test_asset_updates.py Outdated Show resolved Hide resolved
rotkehlchen/globaldb/updates.py Outdated Show resolved Hide resolved
rotkehlchen/globaldb/updates.py Outdated Show resolved Hide resolved
rotkehlchen/tests/unit/globaldb/test_asset_updates.py Outdated Show resolved Hide resolved
@OjusWiZard OjusWiZard force-pushed the fix/assets branch 3 times, most recently from 4ade245 to 1129359 Compare May 13, 2024 18:52
@yabirgb yabirgb added ready for final review Backend PR ready to be reviewed by great Lefteris and removed ready for peer review Backend PR ready to be reviewed by colleagues labels May 13, 2024
Copy link
Member

@LefterisJP LefterisJP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some smaller comments

rotkehlchen/globaldb/updates.py Outdated Show resolved Hide resolved
rotkehlchen/tests/unit/globaldb/test_asset_updates.py Outdated Show resolved Hide resolved
rotkehlchen/tests/unit/globaldb/test_asset_updates.py Outdated Show resolved Hide resolved
rotkehlchen/tests/unit/globaldb/test_asset_updates.py Outdated Show resolved Hide resolved
Copy link
Member

@LefterisJP LefterisJP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@LefterisJP LefterisJP merged commit 515a6ca into rotki:bugfixes May 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for final review Backend PR ready to be reviewed by great Lefteris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants