Feat (History Events): Consistent free and premium #7923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7923 +/- ##
===========================================
+ Coverage 72.07% 72.14% +0.07%
===========================================
Files 1179 1182 +3
Lines 107927 108747 +820
Branches 12867 12873 +6
===========================================
+ Hits 77783 78460 +677
- Misses 28221 28364 +143
Partials 1923 1923
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
OjusWiZard
added
the
ready for peer review
yabirgb
reviewed
May 13, 2024
OjusWiZard
force-pushed
the
feat/6115
branch
2 times, most recently
from
41d6415
to
88e500b
Compare
yabirgb
reviewed
May 14, 2024
yabirgb
reviewed
May 14, 2024
OjusWiZard
force-pushed
the
feat/6115
branch
5 times, most recently
from
177f9d2
to
147a8bc
Compare
yabirgb
reviewed
May 15, 2024
Signed-off-by: OjusWiZard <[email protected]>
yabirgb
added
ready for final review
LefterisJP
approved these changes
May 15, 2024
There was a problem hiding this comment.
Code changes look good to me. If after this filtering works both for premium and for free and has been tested it's fine. I am not testing it myself though so am taking @OjusWiZard and @yabirgb word for it.
|
Frontend code looks fine, also tried the functionality in frontend and it works |
lukicenturi
approved these changes
May 15, 2024
|
Failed test is a remote error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6115
Checklist
get_history_events()to return consistent results with premium and free modes.