Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add isheating as propery of water heater #82

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

qunh
Copy link

@qunh qunh commented Jan 23, 2025

add isheating as propery of water heater by utilise the function of isHeating () in the instance
plus requirement file update

@ross-w
Copy link
Owner

ross-w commented Jan 23, 2025

Thanks again for your efforts on this. Have you tried this one in a development environment? I'm not sure just adding it as a property would expose anything to HASS (as isHeating doesn't appear to be part of WaterHeaterEntity.)

My understanding is that it either needs to be a new sensor, or in this case, it is probably more relevant for it to be added to extra_state_attributes. That said, I haven't been following the new features in HASS too closely, so maybe I missed some magic auto enrolment thing.

Also, I'm pretty sure (at the very least) it will need to be added to the update method, otherwise isHeating will only ever be updated when HASS first starts up, and not whenever anything changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants