Clean up sentences (white space changes only)

[DLu]

No description provided.

[fujitatomoya]

html artifacts are not posted here by github action, that is strange, but actions are completed.

[christophebedard]

It's because the PR is coming from a fork.

[kscottz]

This isn't as bad as I thought it might be.

I did catch one corner case that might need to get looked at (double space between sentences).

[fujitatomoya]

@DLu thank you very much for this 👍

actually i got question if we should apply this one-sentence-per-line rule to Changelog.rst files, please take a look at my comment??

after all, this PR lgtm.

what can be the next step? after this is merged, revise and review #4592 to apply sphincs-plugin?

IMO, #4592 sphincs plugin is better than easy python script checking #4996.

my thoughts are,

• rebase Sentence checker #4592 after this PR. that means Sentence checker #4592 just enables sphincs-plugin. (because all warnings are addressed here?)
• enable github workflow Sentence checker #4592

please let me know if i am mistaken, happy to help on this development.

[DLu]

It's because the PR is coming from a fork.

On the outside, always lookin in...

I did catch one corner case that might need to get looked at (double space between sentences).

There's more to do, but I wanted to fix this much first

probably we can skip applying this rule to the *Changelog.rst files

Okay by me! I'm happy to roll it back. The style guide should be updated.

unrelated but this is still fine

This one popped up because of my syntax checker.

[christophebedard]

It's because the PR is coming from a fork.

On the outside, always lookin in...

I wanted to enable it even for PR from forks, but there were "security considerations" apparently 😅

[fujitatomoya]

@DLu

so 1st we are taking this change into rolling (backport jazzy and humble), and then start reviewing #4592? what do you think?

[DLu]

so 1st we are taking this change into rolling (backport jazzy and humble), and then start reviewing #4592? what do you think?

I'm fine with that. The purpose of this PR is just to separate the content changes needed from the tooling. This is not the full set of changes that are needed to get #4592 to fully pass.

[fujitatomoya]

@Mergifyio rebase

[mergify]

rebase

❌ Base branch update has failed

Git reported the following error:

Rebasing (1/2)
Auto-merging source/Concepts/Basic/About-Parameters.rst
Auto-merging source/The-ROS2-Project/Contributing/Code-Style-Language-Versions.rst
Auto-merging source/The-ROS2-Project/Contributing/Contributing-To-ROS-2-Documentation.rst
Auto-merging source/Tutorials/Miscellaneous/Deploying-ROS-2-on-IBM-Cloud.rst
CONFLICT (content): Merge conflict in source/Tutorials/Miscellaneous/Deploying-ROS-2-on-IBM-Cloud.rst
error: could not apply f3610ba... Clean up sentences (white space changes only)
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply f3610ba... Clean up sentences (white space changes only)

[fujitatomoya]

Ah, it has been rebased already, i was confused with difference from previous review point, sorry.