Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Zenoh UDP transport #486

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Conversation

Hugal31
Copy link
Contributor

@Hugal31 Hugal31 commented Feb 28, 2025

  • Enable the zenoh/transport_udp feature.
  • Set the Zenoh publishers reliability to best effort if requested by the user.

@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/rmw-zenoh-binaries-for-rolling-jazzy-and-humble/41395/24

@JEnoch
Copy link
Contributor

JEnoch commented Feb 28, 2025

Since eclipse-zenoh/zenoh#1305 a Zenoh Publisher is RELIABLE by default.
Hence this PR fixes the BEST_EFFORT case which was keeping the default RELIABLE setting.
Thanks !

@ahcorde ahcorde merged commit 299ddc7 into ros2:rolling Feb 28, 2025
5 checks passed
@ahcorde
Copy link
Contributor

ahcorde commented Feb 28, 2025

https://github.com/Mergifyio backport jazzy humble

Copy link

mergify bot commented Feb 28, 2025

backport jazzy humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 28, 2025
(cherry picked from commit 299ddc7)
mergify bot pushed a commit that referenced this pull request Feb 28, 2025
(cherry picked from commit 299ddc7)
ahcorde pushed a commit that referenced this pull request Feb 28, 2025
(cherry picked from commit 299ddc7)

Co-authored-by: Hugal31 <[email protected]>
@Yadunund
Copy link
Member

Yadunund commented Mar 3, 2025

@ahcorde did we run CI for all core pkgs with these changes?

Yadunund pushed a commit that referenced this pull request Mar 19, 2025
Yadunund pushed a commit that referenced this pull request Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants