Skip to content

Update lower, upper, effort, and velocity default joint limits#95

Open
Amronos wants to merge 3 commits intoros:rollingfrom
Amronos:set-limits-infinity
Open

Update lower, upper, effort, and velocity default joint limits#95
Amronos wants to merge 3 commits intoros:rollingfrom
Amronos:set-limits-infinity

Conversation

@Amronos
Copy link

@Amronos Amronos commented Feb 7, 2026

Changes from ros/urdfdom#212 (comment) and #83 (comment).
ros/urdfdom#212 should be updated accordingly, or a new PR should be created to update the defaults of these limits.

Signed-off-by: Aarav Gupta <aarav@spikonado.com>
@Amronos Amronos force-pushed the set-limits-infinity branch from 90ba8e0 to b2c944d Compare February 7, 2026 04:06
@Amronos
Copy link
Author

Amronos commented Feb 7, 2026

@saikishor @scpeters please take a look whenever you get the time.

Amronos and others added 2 commits February 10, 2026 00:45
Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com>
Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com>
@Amronos Amronos requested a review from saikishor February 9, 2026 19:18
Copy link
Contributor

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Amronos Amronos changed the title Set lower, upper, effort, and velocity default joint limits to infinity Update lower, upper, effort, and velocity default joint limits Feb 9, 2026
@scpeters
Copy link
Contributor

Thanks for opening the PR!

One thing we need to guarantee is that the behavior of existing URDF (most importantly version 1.0 but also 1.1) does not change. To ensure this, I would need to see a corresponding pull request to urdfdom that does the following:

this may be a little more complicated to implement than I thought, but this is a very widely used file format, and we need to preserve existing behavior.

@Amronos
Copy link
Author

Amronos commented Feb 12, 2026

I don't have the time right now to make a proper PR to urdfdom due to exams but would still like to see this included in the version 1.2 of the spec.
@saikishor Could you please update ros/urdfdom#212 or make a new PR and handle this for me?
If that's not possible, a PR from me would probably come during early April.

@saikishor
Copy link
Contributor

saikishor commented Feb 12, 2026

@Amronos @scpeters I can add the changes in a different PR once ros/urdfdom#212 is merged. I would prefer to leave them separate for now.

Is that fine for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants