Update lower, upper, effort, and velocity default joint limits#95
Update lower, upper, effort, and velocity default joint limits#95Amronos wants to merge 3 commits intoros:rollingfrom
Conversation
Signed-off-by: Aarav Gupta <aarav@spikonado.com>
90ba8e0 to
b2c944d
Compare
|
@saikishor @scpeters please take a look whenever you get the time. |
Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com>
Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com>
|
Thanks for opening the PR! One thing we need to guarantee is that the behavior of existing URDF (most importantly version 1.0 but also 1.1) does not change. To ensure this, I would need to see a corresponding pull request to urdfdom that does the following:
this may be a little more complicated to implement than I thought, but this is a very widely used file format, and we need to preserve existing behavior. |
|
I don't have the time right now to make a proper PR to urdfdom due to exams but would still like to see this included in the version 1.2 of the spec. |
|
@Amronos @scpeters I can add the changes in a different PR once ros/urdfdom#212 is merged. I would prefer to leave them separate for now. Is that fine for you? |
Changes from ros/urdfdom#212 (comment) and #83 (comment).
ros/urdfdom#212 should be updated accordingly, or a new PR should be created to update the defaults of these limits.