Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use atomic bool instead of volatile uint32_t #2357

Open
wants to merge 1 commit into
base: noetic-devel
Choose a base branch
from

Conversation

4c3y
Copy link

@4c3y 4c3y commented Oct 27, 2023

  • Use boost::atomic<bool> instead of volatile uint32_t
  • Replaced int literals with bool literals
  • Fixed #include order

@peci1
Copy link
Contributor

peci1 commented Sep 5, 2024

This PR would break the existing API and ABI. Such changes are usually not accepted for released ROS distros.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants