Allow forwarding of working directory and launch file args to add_rostest from gtest wrapper functions #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test from gtest wrapper function
…o deal with launch file args vs ARGN
|
Generally, this PR could work. A test-case (utilizing the added features) is almost a must to be sure it actually works. Could you also describe the scenario where this PR helps? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not great with cmake, so there very well may be a better way to do what I'm trying to do here. If this is acceptable, I'll add some unit tests and what not, but I wanted to go ahead and open the PR to get some feedback on whether or not there's a better way to do this.
This would have been more straightforward using a named argument for the sources, but I didn't want to break backwards compatibility.