Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread is stucking on shutdown #2281

Open
wants to merge 1 commit into
base: noetic-devel
Choose a base branch
from
Open

Thread is stucking on shutdown #2281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tools/roslaunch/src/roslaunch/parent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,12 @@ def _stop_infrastructure(self):

if self.server:
try:
self.server.shutdown("roslaunch parent complete")
import sys
if sys.version_info >= (3, 0):
# https://github.com/ros/ros_comm/issues/2238
self.server.shutdown()
else:
self.server.shutdown("roslaunch parent complete")
except:
# don't let exceptions halt the rest of the shutdown
pass
Expand Down