support rosbag play --loop in rospy.Timer
#2257
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I fail to understand why this issue still exists after all these years. Without the patch the Timer thread just dies on rosbag loop *with no way of detecting and restarting it* easily. Instead the patch changes the behavior to assume it slept enough and calls the callback. If application logic requires resets, this can be detected from the TimerEvent passed to the callback.
tamspr2
pushed a commit
to TAMS-Group/jsk_recognition
that referenced
this pull request
Jul 6, 2022
due to rosbag loop. Without this patch, the buffer fills up continuously. This relies on ros/ros_comm#2257 to fix rospy.Timer with rosbag loops as well.
tamspr2
pushed a commit
to TAMS-Group/jsk_recognition
that referenced
this pull request
Jul 6, 2022
due to rosbag loop. Without this patch, the buffer fills up continuously. This relies on ros/ros_comm#2257 to fix rospy.Timer with rosbag loops as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fail to understand why this issue still exists after all these years, though I really should not be surprised...
Without the patch the Timer thread just dies on rosbag loop with no way of detecting and restarting it easily.
The patch changes the behavior to assume it slept enough and calls the callback again.
If the callback logic requires resets, this can be detected from the TimerEvent passed to the callback.
This addresses a use case that is currently fully broken, so there is no need to worry about incompatible behavior.