Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Ignition Edifice packages #131

Merged
merged 3 commits into from
Nov 17, 2021
Merged

Conversation

chapulina
Copy link
Contributor

Similar to #129, periodic update to the latest versions.

I'd like to get this in before #128 , to reduce that PR

One thing I did differently here was to remove the revision -1 from the versions, because some packages were released as -2

@nuclearsandwich
Copy link
Contributor

One thing I did differently here was to remove the revision -1 from the versions, because some packages were released as -2

In general I'm very much a fan of fully specified releases since there's really no better expression of what we want in the bootstrap repository than these configs. But since we don't have any enforcement that every clause in a filter expression actually matches a package I can't really justify being dogmatic about it. I think it does make sense to include the - separator literal to prevent a version such as 1.4.1* from matching 1.4.11 in addition to the intended 1.4.1-2.

Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if we don't include the debinc value in the fixed portion of the version glob I think it's best to include the debinc separator character - to prevent unintended matches.

Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Copy link
Contributor Author

Makes sense, added the - back in 35e4b31

Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was one "missed" edit common to both files but other than those it looks good and passes CI.

config/ignition_edifice_debian_buster.yaml Outdated Show resolved Hide resolved
config/ignition_edifice_ubuntu_focal.yaml Outdated Show resolved Hide resolved
Signed-off-by: Louise Poubel <[email protected]>
@nuclearsandwich nuclearsandwich merged commit dab1f5e into master Nov 17, 2021
@nuclearsandwich
Copy link
Contributor

Import jobs:
https://build.ros.org/job/import_upstream/191/
https://build.ros2.org/job/import_upstream/346/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants