Support docker::registry_mirror config option. #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Docker Hub's new rate limits[1] most buildfarm configurations will hit the rate limit during normal operation. This would allow you to specify a registry mirror to pull from. One recommendded configuration would be to follow Docker's recipe for a read-through caching mirror[2]. To enable this new option add a hiera config field of `docker::registry_mirror` to your common.yaml hiera configuration in buildfarm_deployment_config. [1]: https://www.docker.com/increase-rate-limits [2]: https://docs.docker.com/registry/recipes/mirror/
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/read-through-caching-container-registry/17477/1 |
j-rivero
reviewed
Dec 4, 2020
| @@ -0,0 +1,4 @@ | |||
| { | |||
| <% if ! scope.function_hiera(["docker::registry_mirror"], "").empty? %> "registry-mirrors": ["<%= scope.function_hiera(["docker::registry_mirror"])%>"],<% end -%> | |||
There was a problem hiding this comment.
I'm unsure about how puppet is going to return the scope.function_hiera(["docker::registry_mirror"]) being docker::registry_mirror an array. Probably worth to take a look once running this to be sure the format (plain string?) is the expected.
|
Changes looks good to me with the exception of minor comment about the format of the data. The configuration seems the right one to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Docker Hub's new rate limits1 most buildfarm configurations will hit
the rate limit during normal operation. This would allow you to specify
a registry mirror to pull from. One recommendded configuration would be
to follow Docker's recipe for a read-through caching mirror2.
To enable this new option add a hiera config field of
docker::registry_mirrorto your common.yaml hiera configuration inbuildfarm_deployment_config.
🚧
Note for reviewers: I haven't tested this yet. The canonical buildfarms had their changes manually deployed as a proof-of-concept. If anyone does try this out and find it working I would love to hear about it.