Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcr demo #306

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

vcr demo #306

wants to merge 2 commits into from

Conversation

maelle
Copy link
Member

@maelle maelle commented Oct 13, 2020

following discussion with @stitam

@stitam stitam mentioned this pull request Oct 29, 2020
4 tasks
@Aariq
Copy link
Collaborator

Aariq commented Nov 2, 2022

Hey @stitam, I used vcr for tests in another project and have a decent handle on how it works. Are we still interested in implementing it for testing webchem? The downside is that changes to APIs won't cause our tests to fail (unless we keep some tests that query the API).

@stitam
Copy link
Contributor

stitam commented Nov 2, 2022

Hi @Aariq, it takes forever to pass all the checks before merging a PR so I think vcr would be useful. To manage the downside, do you think e.g. manually rebuilding the vcr records every now and then would be feasible? I doubt this "every now and then" could be automated :/

@maelle
Copy link
Member Author

maelle commented Nov 3, 2022

there is also {httptest} , alternatively. It's more actively maintained, and if you were to switch to httr2, switching your tests to {httptest2} would be easier than from {vcr} to {httptest2}.

@Aariq
Copy link
Collaborator

Aariq commented Nov 3, 2022

Maybe I'll try out httptest for my other, simpler, project and report back.

@maelle
Copy link
Member Author

maelle commented Nov 3, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants