Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare all SQLite databases locally #81

Merged
merged 13 commits into from
Jun 2, 2024
Merged

Conversation

stitam
Copy link
Collaborator

@stitam stitam commented May 29, 2024

Related to issues #77, #82, #83.

This PR implements conversion to SQLite locally within taxizedb. Orginal code for conversion to SQLite:

These were re-implemented within the respective db_download_*() functions.

The URL for COL seemed to point to GBIF so I replaced the URL with a new one.

The URL for WFO did not work because of an expired certificate. The new Zenodo URL works properly.

@stitam stitam marked this pull request as draft May 29, 2024 07:25
@stitam stitam changed the title Prepare GBIF SQLite database locally Prepare all SQLite databases locally May 30, 2024
@stitam
Copy link
Collaborator Author

stitam commented May 30, 2024

With all the failing tests it was hard for me to tell whether my GBIF implementation was working properly, so I decided to combine multiple issues in the same PR and fix them together.

Note that until 2019 COL used integer taxon IDs (e.g. 3960765) but since 2020 COL uses character IDs (e.g. C66T4). This impacted a number of examples and tests so these were also updated.

@stitam stitam marked this pull request as ready for review May 30, 2024 15:21
@stitam stitam merged commit bc00b7b into ropensci:master Jun 2, 2024
5 checks passed
@stitam stitam deleted the issue77 branch June 2, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant