Skip to content

Commit

Permalink
Fix typos and tests
Browse files Browse the repository at this point in the history
  • Loading branch information
florianm committed Mar 6, 2024
1 parent c1bf83f commit d1eabcc
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 4 deletions.
4 changes: 2 additions & 2 deletions R/ru_setup.R
Original file line number Diff line number Diff line change
Expand Up @@ -624,7 +624,7 @@ get_default_odkc_version <- function() {
#' Show whether a given semver is greater than a baseline version.
#'
#' @param sv The semver to compare as character
#' ("2023.5.1", 1.5.0", "1.5"), or numeric (1.5).
#' ("2023.5.1", "1.5.0", "1.5"), or numeric (1.5).
#' The value is always parsed with `semver::parse_semver()`.
#' Default: get_default_odkc_version().
#' @param to The semver to compare to as string. Although semver can parse
Expand Down Expand Up @@ -655,7 +655,7 @@ semver_gt <- function(sv = get_default_odkc_version(), to = "1.5.0") {
#' Show whether a given semver is lesser than a baseline version.
#'
#' @param sv The semver to compare as character
#' ("2023.5.1", 1.5.0", "1.5"), or numeric (1.5).
#' ("2023.5.1", "1.5.0", "1.5"), or numeric (1.5).
#' The value is always parsed with `semver::parse_semver()`.
#' Default: get_default_odkc_version().
#' @param to The semver to compare to as string. Although semver can parse
Expand Down
2 changes: 1 addition & 1 deletion man/semver_gt.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/semver_lt.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions tests/testthat/test-attachment_get.R
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,11 @@ test_that("get_one_attachment handles repeat download and NA filenames", {
fs::dir_ls(t) %>% fs::file_delete()

url <- get_test_url()
un <- get_test_un()
pw <- get_test_pw()
pid <- get_test_pid()
fid <- get_test_fid()
ruODK::ru_setup(url=url, un=un, pw=pw)
iid <- ruODK::submission_list(pid = pid, fid = fid)$instance_id
att_list <- ruODK::attachment_list(pid = pid, fid = fid, iid = iid)
fn <- att_list$name[1]
Expand Down

0 comments on commit d1eabcc

Please sign in to comment.