Skip to content

Commit

Permalink
Fix #207 (#208)
Browse files Browse the repository at this point in the history
  • Loading branch information
chainsawriot authored Dec 19, 2024
1 parent 7068815 commit 55c8038
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 1 deletion.
1 change: 1 addition & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,4 @@ notes.R
^revdep$
^LICENSE.note$
^.editorconfig$
^tests/testdata/issue81.ods$
4 changes: 4 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# readODS 2.3.2

* Fix #207, trim off large or unused test files

# readODS 2.3.1

* Undo #173, use `cpp11` like 2.2.0
Expand Down
Binary file removed tests/testdata/layout_test.xls
Binary file not shown.
Binary file removed tests/testdata/layout_test.xlsx
Binary file not shown.
4 changes: 3 additions & 1 deletion tests/testthat/test_issue81.R
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,14 @@ test_that("issue 81, correctness", {
})

test_that("issue 81 real test", {
skip_if(!file.exists("../testdata/issue81.ods"))
file <- "../testdata/issue81.ods"
res <- read_ods(file, sheet = 2, skip = 4, as_tibble = FALSE)
expect_equal(sum(is.na(res[,1])), 0)
})

test_that("issue 84", {
skip_if(!file.exists("../testdata/issue81.ods"))
file <- "../testdata/issue81.ods"
expect_error(read_ods(file, sheet = "Leavers"), NA)
})
})

0 comments on commit 55c8038

Please sign in to comment.