Fix #211

ropensci · Jan 12, 2025 · 0e4be3f · 0e4be3f
1 parent 6b15d06
commit 0e4be3f
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 1 deletion.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -25,7 +25,7 @@ URL: https://docs.ropensci.org/readODS/, https://github.com/ropensci/readODS
 BugReports: https://github.com/ropensci/readODS/issues
 Imports:
     cellranger,
-    minty,
+    minty (>= 0.0.5),
     stringi,
     tibble,
     vctrs (>= 0.4.2),

diff --git a/NEWS.md b/NEWS.md
@@ -2,6 +2,7 @@
 
 * Fix #207, trim off large or unused test files
 * Fix #209, require R >= 4.0.0 due to `cpp11`
+* Fix #211, fix a bug (in minty) for parsing cells with only spaces
 
 # readODS 2.3.1
 

diff --git a/tests/testdata/test_may_make_read_ods_crash_v2.ods b/tests/testdata/test_may_make_read_ods_crash_v2.ods
diff --git a/tests/testthat/test_read_ods.R b/tests/testthat/test_read_ods.R
@@ -165,3 +165,7 @@ test_that("Warns of empty sheet", {
         expect_warning(read_fods("../testdata/empty.fods"))
     })
 })
+
+test_that("minty v0.0.5 #211", {
+    expect_error(read_ods("../testdata/test_may_make_read_ods_crash_v2.ods", trim_ws = TRUE), NA)
+})