-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporating the latest round of API changes #39
base: master
Are you sure you want to change the base?
Conversation
Hey Russ, can you summarize what this PR does? Also I see that the tests on CI aren't passing, can you comment and/or make sure they pass? |
Can we also drop all those tests that we talked about? |
It's the remaining code to catch up with the API:
We can remove tests but some of the suggestions you made have code changes now, especially get_fields() and, argument changes to search_pv() I'm not sure what's wrong with the build. I bumped versions in the workflow to get rid of deprecated warnings but didn't intentionally change anything, I can try reverting. It's working in my repo but it's trying to make API calls here. There are skip_on_cran()s in the tests but they're running and so are the dont_run examples. |
Things to note:
Should we bump the version to 1.0.0 because of the breaking changes?