Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve and test osmchange_*() #11

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Improve and test osmchange_*() #11

merged 2 commits into from
Feb 21, 2024

Conversation

jmaspons
Copy link
Collaborator

TODO: remove fixes in tests after #9 and #10

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (984987d) 81.43% compared to head (573229b) 85.09%.

Files Patch % Lines
R/R_to_xml.R 0.00% 2 Missing ⚠️
R/osmapiR_methods.R 93.75% 1 Missing ⚠️
R/osmchange.R 97.05% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
+ Coverage   81.43%   85.09%   +3.66%     
==========================================
  Files          21       21              
  Lines        1578     1590      +12     
==========================================
+ Hits         1285     1353      +68     
+ Misses        293      237      -56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmaspons jmaspons merged commit fd62b74 into main Feb 21, 2024
9 checks passed
@jmaspons jmaspons deleted the osmchange branch February 21, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant