Review 2 of Softwarereview_reviewer.pt.Rmd-pt-auto #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should the PR be actually to the working branch? Did I do something wrong here? |
|
@samuel-carleial Yes! This PR should aim to the working branch, instead of targeting the main branch. Therefore, the target branch should be |
|
Ok eu vou tentar fazer direto depois. Obrigado pela resposta
…On Tue, 26 Nov 2024, 21:57 Pedro Faria, ***@***.***> wrote:
@samuel-carleial <https://github.com/samuel-carleial> Yes! This PR should
aim to the working branch, instead of targeting the main branch.
Therefore, the target branch should be
ropensci:softwarereview_reviewer.pt.Rmd-pt-auto
—
Reply to this email directly, view it on GitHub
<#853 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJ4V64NDNSKIITCUEWHYAST2CTOFFAVCNFSM6AAAAABSRKK4EOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBRHEZDCMJUGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@samuel-carleial Here are instructions on how to change the target branch: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-base-branch-of-a-pull-request I can also make the change; let me know. Thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pedropark99
Here is my R2 to this task. I had a detailed look on the english version to the side, and tried to improve the PT-BR translation. Espero que tenha melhorado.