[hist] Add first microbenchmark for RRegularAxis
#19458
Open
+59
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 21 files 21 suites 3d 8h 6m 17s ⏱️ For more details on these failures, see this check. Results for commit 4e93e3b. ♻️ This comment has been updated with latest results. |
bellenot
approved these changes
Jul 25, 2025
In ROOT, we traditionally had benchmarks separated in the rootbench repository. However, for the new histv7 package, they should evolve together with the code. Therefore this commit introduces a benchmark subdirectory, which is only built with the "hidden" configuration flag histv7_benchmark. For the standalone build, there is a new option BUILD_BENCHMARK. If enabled (the default) and the benchmark dependency is found, building will also produce all benchmark binaries.
|
Should the option be off by default? After all one only wants to enable it when specifically running the benchmarks, which is a very rare occasion in general |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ROOT, we traditionally had benchmarks separated in the
rootbenchrepository. However, for the newhistv7package, they should evolve together with the code. Therefore this commit introduces abenchmarksubdirectory, which is only built with the "hidden" configuration flaghistv7_benchmark.For the standalone build, there is a new option
BUILD_BENCHMARK. If enabled (the default) and the benchmark dependency is found, building will also produce all benchmark binaries.