[RF] Serialize RooWorkspace snapshots in a more compressed way #19380
+99
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guitargeek
changed the title
guitargeek
force-pushed
the
issue-18032
branch
2 times, most recently
from
7dc7ef7 to
42cf411
Compare
Open
1 task
Test Results 21 files 21 suites 3d 7h 20m 5s ⏱️ Results for commit 701a694. ♻️ This comment has been updated with latest results. |
This commit eliminates the *huge* overhead when storing parameter snapshots in a RooWorkspace. A "snapshot" actually needs to contain very little info. What's happening right now is that for storing a Snapshot, RooFit creates a `RooRealVar` clone for each variable, which is `sizeof(RooRealVar) = 1000` bytes plus manually-allocated overhead (e.g. for binning info). This memory overhead can be eliminated in the custom `RooWorkspace::Streamer`, only storing the information necessary for a snapshot. And when reading back the file, the `RooRealVar` clones will be instantiated so there is not change in behavior for the user. Closes root-project#18032.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit eliminates the huge overhead when storing parameter snapshots in a RooWorkspace.
A "snapshot" actually needs to contain very little info. What's happening right now is that for storing a Snapshot, RooFit creates a
RooRealVarclone for each variable, which issizeof(RooRealVar) = 1000bytes plus manually-allocated overhead (e.g. for binning info).This memory overhead can be eliminated in the custom
RooWorkspace::Streamer, only storing the information necessary for a snapshot. And when reading back the file, theRooRealVarclones will be instantiated so there is not change in behavior for the user.Closes #18032.