Skip to content

[TEST] trigger pymva crashes with torch::jit and regex #19210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[TEST] trigger pymva crashes with torch::jit and regex #19210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/root-ci-config/buildconfig/global.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ testing=ON
tmva-cpu=ON
tmva-gpu=OFF
tmva-cudnn=OFF
tmva-pymva=OFF
tmva-pymva=ON
tmva-rmva=OFF
tmva-sofie=OFF
tmva=ON
Expand Down
9 changes: 5 additions & 4 deletions .github/workflows/root-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,11 +363,12 @@ jobs:
include:
- image: fedora41
- image: fedora42
overrides: ["CMAKE_CXX_STANDARD=23"]
overrides: ["CMAKE_BUILD_TYPE=Debug", "CMAKE_CXX_STANDARD=23"]
- image: fedora43
overrides: ["CMAKE_CXX_STANDARD=23"]
overrides: ["CMAKE_BUILD_TYPE=Debug", "CMAKE_CXX_STANDARD=23"]
is_special: true
- image: alma8
overrides: ["CMAKE_BUILD_TYPE=Debug"]
- image: alma9
overrides: ["CMAKE_BUILD_TYPE=Debug", "CMAKE_CXX_FLAGS=-Wsuggest-override"]
- image: alma10
Expand All @@ -387,11 +388,11 @@ jobs:
- image: alma9
is_special: true
property: march_native
overrides: ["CMAKE_BUILD_TYPE=RelWithDebInfo", "CMAKE_CXX_FLAGS=-march=native", "CMAKE_C_FLAGS=-march=native", "builtin_zlib=ON", "builtin_zstd=ON"]
overrides: ["CMAKE_BUILD_TYPE=Debug", "CMAKE_CXX_FLAGS=-march=native", "CMAKE_C_FLAGS=-march=native", "builtin_zlib=ON", "builtin_zstd=ON"]
- image: alma9
is_special: true
property: arm64
overrides: ["CMAKE_BUILD_TYPE=RelWithDebInfo", "builtin_zlib=ON", "builtin_zstd=ON"]
overrides: ["CMAKE_BUILD_TYPE=Debug", "builtin_zlib=ON", "builtin_zstd=ON"]
architecture: ARM64
- image: alma9-clang
is_special: true
Expand Down
2 changes: 2 additions & 0 deletions interpreter/CppInterOp/lib/CppInterOp/Compatibility.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,8 @@ inline void codeComplete(std::vector<std::string>& Results,
// append cleaned results
for (auto& r : results) {
// remove the definition at the beginning (e.g., [#int#])
// trigger the failure
r = std::regex_replace(r, std::regex("\\[\\#.*\\#\\]"), "");
r = removeDefinition.sub("", r, &error);
if (!error.empty()) {
Err = llvm::make_error<llvm::StringError>(error,
Expand Down
Loading