-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[roottest] build libEvent with cmake [work in progress] #19173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
linev
wants to merge
11
commits into
root-project:master
Choose a base branch
from
linev:_event
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 20 files 20 suites 3d 16h 25m 9s ⏱️ For more details on these failures, see this check. Results for commit 8b00a40. ♻️ This comment has been updated with latest results. |
Keep dt_Makefile to let use Makefile-based tests in different places
Instead build new library and manage own sources - just reuse existing library. As it was before used in makefile
Use central libTestIoEvent from `roottest/root/io/event` Compile macros, generate several files and one reference file Run drawing with several modes
Reuse libTestIoEvent with small modifications Simplify runretobjTest.C to avoid testing old CINT problems
Re-enable several tests like all testFriend.C macros Delete unused files
Very similar to treeformula/event testing, therefore reuse code from there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
io/event
to cmakeWork in progress